-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Creating SMTP provider #29968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creating SMTP provider #29968
Conversation
|
I think this provider will also need to be added to the pre installed ones: Lines 690 to 699 in 275ef6c
This is because currently the ability to send email is coupled with core and assuming we will deprecate the core operator in favor of the provider one we need the provider to be installed with Airflow. |
@eladkal I cannot add before releasing the provider, because the Airflow setup uses PyPI package and not the local one, so as I mentioned in the description, I will create a new PR to do that once the provider is released. |
| Specify the extra parameters (as json dictionary) | ||
|
|
||
| * ``from_email``: The email address from which you want to send the email. | ||
| * ``disable_ssl``: If set to true, then a non-ssl connection is being used. Default is false. Also note that changing the ssl option also influences the default port being used. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not mandatory but would be nice to have it as boolean field in the UI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I already added it (line)
potiuk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Nice one @hussein-awala ! |
closes: #28494
This PR creates a new provider SMTP to manage the connections, hooks and operators related to SMTP/email sending.
Once this provider is released, a second PR will be created to add it as pre-installed provider, deprecate the
airflow.operators.email.EmailOperatorand let it extends the new one with a support for Airflow config for b/c, and provide a new implementation for email backend (based on the hook).